Use .data.rel.ro section for message globals.#26671
Draft
copybara-service[bot] wants to merge 1 commit intomainfrom
Draft
Use .data.rel.ro section for message globals.#26671copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
Putting message globals on .data.rel.ro section has two benefits:
(1) makes it truly read only and forces seg faults rather than subtle bug when
users unintentionally mutate the default instance.
(2) collocates it on the same section where the type's other const data (vtbl).
PiperOrigin-RevId: 892545502
copybara-service
bot
force-pushed
the
test_892545502
branch
from
187f324 to
72c6729
Compare
copybara-service
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use .data.rel.ro section for message globals.
Putting message globals on .data.rel.ro section has two benefits:
(1) makes it truly read only and forces seg faults rather than subtle bug when
users unintentionally mutate the default instance.
(2) collocates it on the same section where the type's other const data (vtbl).